Bugfix: Bump up libOpenflow version #5157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
|
We don't need the fixes in ofnet? |
No, the changes in ofnet is for PacketIn2 only, but we do not introduce PacketIn2 in antrea v1.11 |
luolanzone
approved these changes
Jun 21, 2023
|
@wenyingd there is a typo in the PR and commit messages: PackintIn -> PacketIn |
This is to resolve an issue when unmarshaling IP packet which may lead to incorrect field values in PacketIn meesages. The issue is because the existing code uses a pointer reference to set byte slice fields when unmarshaling the mesages, and libOpenlow reuses the buffer to process the next messages. Signed-off-by: wenyingd <wenyingd@vmware.com>
wenyingd
force-pushed
the
unmarshal_byteslice_release1.11
branch
from
1d9f36a
to
035f8d2
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve an issue when unmarshaling IP packet which may lead to incorrect field values in PacketIn meesages. The issue is because the existing code uses a pointer reference to set byte slice fields when unmarshaling the mesages, and libOpenlow reuses the buffer to process the next messages.