-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise antctl mc deploy
to support manifest update
#5257
Conversation
antctl mc deploy
to support manifest updateantctl mc deploy
to support manifest update
7fdf16a
to
dcce1d7
Compare
In commit message, consider changing "Refine" to "Revise". "If the CRD is already existing" -> If a CRD to import already exists" |
dcce1d7
to
715a9c4
Compare
Commit title and message are updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change "If a CRD to import already exists" to "If a CR to create already exists"?
In our manifests, there are both CRDs and CRs (Service/Deployment etc), so maybe I can rewrite it as |
715a9c4
to
f01a02b
Compare
I feel you should just say "a resource to create". |
f01a02b
to
58a7cff
Compare
Updated the message. Thanks. |
/test-multicluster-e2e |
If a resource to create already exists, the command `antctl mc deploy` will do nothing even when the manifests are changed. Revise the code to apply changes if there is any manifest update. Signed-off-by: Lan Luo <luola@vmware.com>
58a7cff
to
e3419db
Compare
Rebased and rerun the test. |
/skip-all |
If a resource to create already exists, the command
antctl mc deploy
will do nothing even when the manifests are changed. Revise the code to apply changes if there is any manifest update.