-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Antrea IPAM for Antrea native secondary network support #5427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not many comment from me. Maybe someone more familiar with the IPAM code should also review. Maybe @gran-vmv ?
1a7da4e
to
7811b16
Compare
72fb4f1
to
d7ebbc8
Compare
LGTM for IPAM part. |
For Multus, it is documented here: https://github.com/antrea-io/antrea/blob/main/docs/antrea-ipam.md#ipam-for-secondary-network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of nits
d7ebbc8
to
30b6460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
30b6460
to
3e316f6
Compare
3e316f6
to
ee1b15e
Compare
This commit changes Antrea managed secondary networks to use Antrea IPAM for interface IP address allocation, and no longer use Whereabouts. Signed-off-by: Jianjun Shen <shenj@vmware.com>
ee1b15e
to
b6f78ee
Compare
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit changes Antrea managed secondary networks to use Antrea IPAM for interface IP address allocation, and no longer use Whereabouts.
Issue: #5278