-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Windows OVS Container to run on pristine Host Environment #5440
Conversation
9eadc53
to
1fb02d2
Compare
1fb02d2
to
680fb98
Compare
680fb98
to
7f09ecb
Compare
7f09ecb
to
cfae9f9
Compare
@NamanAg30 please update |
cfae9f9
to
518b34c
Compare
518b34c
to
49f37de
Compare
build/yamls/windows/containerd-with-ovs/containerd-with-ovs.yml
Outdated
Show resolved
Hide resolved
build/yamls/windows/containerd-with-ovs/conf/Run-AntreaOVS-Containerd.ps1
Outdated
Show resolved
Hide resolved
1d97f0c
to
3a9df86
Compare
$driverStatus = netcfg -q ovsext | ||
if ($driverStatus -like '*not installed*') { | ||
# Install OVS Driver | ||
netcfg -l $mountPath/openvswitch/driver/ovsext.inf -c s -i OVSExt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use $OVSDriverDir\ovsext.inf
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not updated.
2430189
to
8cae24e
Compare
$driverStatus = netcfg -q ovsext | ||
if ($driverStatus -like '*not installed*') { | ||
# Install OVS Driver | ||
netcfg -l $mountPath/openvswitch/driver/ovsext.inf -c s -i OVSExt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not updated.
8cae24e
to
8cead31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the Windows documentation has become very hard for users to follow, due to the 3 supported installation methods, the different version combinations (K8s, containerd) and signed vs unsigned OVS driver. It needs to be improved. However, I am aware that this PR has been in the review process for a while, and improving the documentation is out-of-scope. So I will open an issue to track this.
eb6f178
to
b4ef3b1
Compare
Support installation of signed ovs kernel driver from inside container when no installed on host. Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
b4ef3b1
to
13c9f71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-windows-containerd-conformance |
Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
…rea-io#5440) Support installation of signed ovs kernel driver from inside container when not installed on host. Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
…rea-io#5440) Support installation of signed ovs kernel driver from inside container when not installed on host. Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
Support installation of signed ovs kernel driver from inside container when not installed on host. Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
for #5249