Fix NP not working on hairpin Service connection #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It means that NetworkPolicy will never block hairpin connections. Is that right? |
GraysonWu
force-pushed
the
fix-np-hairpin
branch
from
9eb2b3b
to
ec176ee
Compare
Yes. But you still can use |
GraysonWu
force-pushed
the
fix-np-hairpin
branch
from
ec176ee
to
8fa3076
Compare
luolanzone
reviewed
Nov 9, 2023
GraysonWu
force-pushed
the
fix-np-hairpin
branch
from
8fa3076
to
59c17d0
Compare
tnqn
reviewed
Nov 9, 2023
GraysonWu
force-pushed
the
fix-np-hairpin
branch
from
59c17d0
to
5206ad3
Compare
tnqn
reviewed
Nov 10, 2023
GraysonWu
force-pushed
the
fix-np-hairpin
branch
from
5206ad3
to
ef3bc33
Compare
|
The changed test is failing |
Fix antrea-io#5681 Network policy didn't work when using a server Pod to establish a connection to the service provided by itself. This hairpin service connection initiated through a local Pod will be SNATed to the gateway IP, which will prevent it from being correctly categorized by the network policy during the Ingress rule enforcement. This commit added a bypass flow to always allow the hairpin service connection to address this issue. Given we don't consider self-access blocking to be a valid case. Signed-off-by: graysonwu <wgrayson@vmware.com>
GraysonWu
force-pushed
the
fix-np-hairpin
branch
from
ef3bc33
to
70f3e1b
Compare
|
/test-all |
tnqn
added
the
action/release-note
|
@GraysonWu please backport it to 1.12-1.14 |
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5681
Network policy didn't work when using a server Pod to establish a connection to the service provided by itself. This hairpin service connection initiated through a local Pod will be SNATed to the gateway IP, which will prevent it from being correctly categorized by the network policy during the Ingress rule enforcement.
This commit added a bypass flow to always allow the hairpin service connection to address this issue. Given we don't consider self-access blocking to be a valid case.