-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Traceflow API v1beta1 #5689
Use Traceflow API v1beta1 #5689
Conversation
c600c26
to
d5f88aa
Compare
/test-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the test/e2e/traceflow_test.go? It still uses v1alpha1
. Please help to double check if there is any other file using the old version. Thanks.
test/e2e/traceflow_test.go has been updated in #5667 |
Looks like @antoninbas also left a comment here #5667 (review) to make version update as a separate PR. I think you can make all version update related changes here and update the title and description. |
Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests. Fixes antrea-io#5656 Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
d5f88aa
to
f87b4ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@luolanzone Does it require to be backported to release-1.13 ? as traceflow API was promoted to v1beta1 in release-1.13 but these code changes were missed. |
It should has no function impact but I feel we'd better to backport it to keep version consistent. @tnqn @antoninbas any suggestion? |
/test-e2e |
@luolanzone I think if we group all missing v1alpha1 -> v1beta1 changes in one PR, then we can backport it if we want. I don't think this impacts users, given that we agreed a while back that Traceflows were a special type of CR (short-lived). |
@antoninbas @tnqn , We need traceflow v1alpha1 -> v1beta1 migration changes for req wrt #5667, hence are targeting early merge for #5689 , could you help with the further review and merge |
/skip-conformance |
/skip-networkpolicy |
@Atish-iaf please take care of backporting as needed |
Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests.
Fixes #5656
Signed-off-by: Kumar Atish atish.iaf@gmail.com