Make Pod securityContext configurable in antrea Helm chart #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on some K8s distributions, users may want to adjust the securityContext for antrea-agent containers. This is reserved for "power users", and most users should not modify the default values. When modifying the securityContext, some Antrea functions may break. For antrea-io#5707 Signed-off-by: Antonin Bas <abas@vmware.com>
tnqn
approved these changes
Nov 17, 2023
Comment on lines
+109
to
+112
| {{- range $k, $v := .Values.agent.installCNI.extraEnv }} | ||
| - name: {{ $k | quote }} | ||
| value: {{ $v | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
what env vars will it be used to inject? For skipping loading OVS module?
There was a problem hiding this comment.
yes, I was thinking that it was a possible option. But in the context of this PR, I just wanted to address the discrepancy with the antrea-agent container.
|
/test-all |
1 similar comment
|
/test-all |
antoninbas
deleted the
make-pod-securityContext-configurable-in-helm-chart
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on some K8s distributions, users may want to adjust the securityContext for antrea-agent containers. This is reserved for "power users", and most users should not modify the default values. When modifying the securityContext, some Antrea functions may break.
For #5707