-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support secondary network without IPAM #5762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if len(podCNIInfo.Interfaces) == 0 { | ||
// Return error to requeue and retry. | ||
return err | ||
} | ||
// We do not return error to retry, if at least one secondary network is configured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you remember why we have this special case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just that Arun wants to simplify the logic. We can fix in future (but I do feel there is complexity to fix partial failure or support network list update).
@@ -70,6 +70,14 @@ const ( | |||
} | |||
}` | |||
|
|||
netAttachTemplateNoIPAM = `{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/netAttachTemplateNoIPAM/netAttachNoIPAMTemplate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
When the secondary network configuration in NetworkAttachmentDefinition does not include IPAM configuration, simply do not allocate and configure IP addresses for the secondary interfaces. Signed-off-by: Jianjun Shen <shenj@vmware.com>
/test-all |
When the secondary network configuration in NetworkAttachmentDefinition does not include IPAM configuration, simply do not allocate and configure IP addresses for the secondary interfaces.
Closes: #5693