-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Endpoint Querier RuleIndex In Response #5783
Conversation
// an AddressGroup can only be referenced in a rule once | ||
break | ||
} | ||
} | ||
// ingressIndex/egressIndex indicates the rule index among this policy's ingress/egress rules | ||
// Antrea Native NP rules priorities are set as index, but KNP rules have the same default rule priorities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the reference to "priorities" here. This seems like a regular index to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Please also add comments on why the index increment is removed from the original place as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comments.
Probably no need to backport since this has been the behavior for a very long time, unless someone is asking for it. |
e3e0d16
to
8c00792
Compare
Sure, it's just needed for #5740 . Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The current endpoint querier rule index shows the index of the rule among all matched rules in the policy for this endpoint, which is not super useful for the users. This change updates the rule index to show the rule index among all rules in the policy. Fixes antrea-io#5782 Signed-off-by: Qiyue Yao <yaoq@vmware.com>
8c00792
to
c1faf9b
Compare
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
The current endpoint querier rule index shows the index of the rule among all matched rules in the original policy for this endpoint.
This change updates the rule index to show the rule index among all rules in the original policy.
Fixes #5782