-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CNI plugins from v1.3.0 to v1.4.0 #5813
Conversation
Signed-off-by: Lan Luo <luola@vmware.com>
/test-all |
@luolanzone I forgot that you will need to trigger a build of |
Hi, @antoninbas thanks for reminder, I triggered the workflow, but looks like it has a problem to get the Windows cni file from github, I tried in a linux host, download works fine. I will rerun the workflow later. |
@luolanzone is the mergeable? |
Hi, @tnqn it's not ready to merge, the Windows base image workflow still failed, Not sure why the curl command on github Windows runner to get the cni binary is so unstable. I had rerun a few times but no luck yet. https://github.com/antrea-io/antrea/actions/runs/7269844266. I will update here if the base image is ready. |
@tnqn , this PR is merge-able now. The base images are updated via this manual workflow build https://github.com/antrea-io/antrea/actions/runs/7354252963/job/20021229050. There is something wrong with curl command, after I replaced it with Windows build-in command 'Invoke-WebRequest', the build can pass. The root cause of curl failure is still not clear yet. I will submit a separate PR to update the Dockerfile to use 'Invoke-WebRequest' to build base Windows images considering it's not used frequently. |
CNI plugin released v1.4.0 with golang 1.21, we can fix more CVEs with a newer golang version.
No need to maintain our own built CNI binary in short term. Fixes #5763
We probably can try to raise an issue first in the CNI binary repo to ask for a new release in the future if a similar case happened.