Enhance HNS network initialization #5841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-windows-all |
XinShuYang
force-pushed
the
enhancewinagent
branch
2 times, most recently
from
fd2cb58
to
c3216c0
Compare
|
/test-windows-containerd-e2e |
wenyingd
reviewed
Jan 11, 2024
|
/test-windows-containerd-e2e |
XinShuYang
force-pushed
the
enhancewinagent
branch
from
c3216c0
to
2221880
Compare
|
/test-windows-containerd-e2e |
|
/test-e2e |
1 similar comment
|
/test-e2e |
XinShuYang
force-pushed
the
enhancewinagent
branch
from
2221880
to
173c269
Compare
|
/test-windows-containerd-e2e |
The current windows agent initialization couldn't guarantee that the `EnableHNSNetworkExtension` was executed after creating the HNS network. In certain corner cases where the Windows agent pod was restarted after creating HNS network, the agent might miss executing `EnableHNSNetworkExtension`. To address this issue, this enhancement runs `EnableHNSNetworkExtension` even if the HNS network has been created, which ensures the OVS Extension is properly enabled. Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang
force-pushed
the
enhancewinagent
branch
from
173c269
to
ba5df70
Compare
|
/test-windows-all |
|
hi @tnqn , do you have more comments? |
tnqn
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
LGTM. However the commit message is not formatted well, I will format it when merging, please apply https://cbea.ms/git-commit/ for future PRs.
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current windows agent initialization couldn't guarantee that the
EnableHNSNetworkExtensionwas executed after creating the HNS network.In certain corner cases where the Windows agent pod was restarted after creating HNS network, the agent might miss executing
EnableHNSNetworkExtension.To address this issue, this enhancement runs
EnableHNSNetworkExtensioneven if the HNS network has been created, which ensures the OVS Extension is properly enabled.