-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance HNS network initialization #5841
Conversation
/test-windows-all |
fd2cb58
to
c3216c0
Compare
/test-windows-containerd-e2e |
/test-windows-containerd-e2e |
c3216c0
to
2221880
Compare
/test-windows-containerd-e2e |
/test-e2e |
1 similar comment
/test-e2e |
2221880
to
173c269
Compare
/test-windows-containerd-e2e |
The current windows agent initialization couldn't guarantee that the `EnableHNSNetworkExtension` was executed after creating the HNS network. In certain corner cases where the Windows agent pod was restarted after creating HNS network, the agent might miss executing `EnableHNSNetworkExtension`. To address this issue, this enhancement runs `EnableHNSNetworkExtension` even if the HNS network has been created, which ensures the OVS Extension is properly enabled. Signed-off-by: Shuyang Xin <gavinx@vmware.com>
173c269
to
ba5df70
Compare
/test-windows-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hi @tnqn , do you have more comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However the commit message is not formatted well, I will format it when merging, please apply https://cbea.ms/git-commit/ for future PRs.
/skip-all |
The current windows agent initialization couldn't guarantee that the
EnableHNSNetworkExtension
was executed after creating the HNS network.In certain corner cases where the Windows agent pod was restarted after creating HNS network, the agent might miss executing
EnableHNSNetworkExtension
.To address this issue, this enhancement runs
EnableHNSNetworkExtension
even if the HNS network has been created, which ensures the OVS Extension is properly enabled.