-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the dependency of openssl library in antrea-controller image #5856
Conversation
7d2374e
to
59f0f2c
Compare
59f0f2c
to
fb139cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we install openssl just for the test? If yes, we can also remove it from antrea-agent and deploy a toolbox pod to check both agent and controller API.
fb139cf
to
5766024
Compare
No, we are not installing openssl only for test, openssl is getting installed as a part of the ovs image(so, ovs might have some dependency on openssl), and we are using the ovs image when building the antrea-agent image so openssl is already a part of antrea-agent, so for that reason I used the above approach. |
5766024
to
b7d55f6
Compare
24c238c
to
4713b8e
Compare
ea4e44c
to
7e436b0
Compare
7e436b0
to
063236f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple more small comments, otherwise LGTM
Configured a toolbox pod to run the e2e test TestAntreaApiserverTLSConfig. Signed-off-by: Pulkit Jain <jainpu@vmware.com>
063236f
to
dfc2da7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TestAntreaApiserverTLSConfig, this e2e test requires the openssl command to be installed in antrea-controller and antrea-agent pod, but adding openssl library to the antrea-controller image unnecessarily increases the size of the antrea-controller image, so I have leveraged the the openssl library which is already installed in the antrea-agent image to perform the e2e test.