-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build different images for antrea-agent and antrea-controller #5902
Conversation
507faab
to
c158d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, two nits.
The PR can't resolve the issue 5691, you may update it as |
Signed-off-by: Pulkit Jain <jainpu@vmware.com>
c158d31
to
d49c38e
Compare
Co-authored-by: Pulkit Jain <jainpu@vmware.com> Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jainpulkit22 I added a commit to your PR for the sake of moving forward. In order to update the build infra, I needed some of the workflow changes to enable pushing the new images to the docker registry. |
/skip-all |
Part of #5691.