Add EgressNode field in Traceflow observation #5949
Conversation
Atish-iaf
force-pushed
the
add-EgressNode-field-in-Traceflow-observation
branch
from
375cd62
to
a910db0
Compare
Atish-iaf
added
the
area/ops/traceflow
There was a problem hiding this comment.
LGTM.
cc @antoninbas @heanlan @yuntanghsu for change to FlowExporter.
| egressNode: | ||
| type: string |
There was a problem hiding this comment.
I don't think we need to add this field for v1alpha1 version. We have promoted the version to v1beta1 half a year ago. @tnqn @antoninbas any thoughts?
There was a problem hiding this comment.
I didn't comment because it's harmless anyway. It's just about whether v1alpha1 client will see the added field, no compatibility impact.
There was a problem hiding this comment.
removed for v1alpha1.
Atish-iaf
force-pushed
the
add-EgressNode-field-in-Traceflow-observation
branch
from
a910db0
to
aa2bfa9
Compare
There was a problem hiding this comment.
Changes to the FlowExporter should probably be reverted (the extra return value can be ignored when calling GetEgress in fillEgressInfo). If we want to add the Egress Node to the exported IPFIX record, it should be done in a separate PR (note that the current version of this PR doesn't actually update the IPFIX record).
pkg/agent/flowexporter/types.go
Outdated
| @@ -86,6 +86,7 @@ type Connection struct { | |||
| EgressIP string | |||
| AppProtocolName string | |||
| HttpVals string | |||
| EgressNode string | |||
There was a problem hiding this comment.
If you are not going to add this information to the exported IPFIX record, then I don't think the FlowExporter changes in this PR make sense.
And if you do want to add the information to the record, it should probably be done in a separate PR (a change to go-ipfix is also required), given that this one is specific to Traceflow.
| @@ -641,14 +641,15 @@ func (exp *FlowExporter) findFlowType(conn flowexporter.Connection) uint8 { | |||
| } | |||
|
|
|||
| func (exp *FlowExporter) fillEgressInfo(conn *flowexporter.Connection) { | |||
| egressName, egressIP, err := exp.egressQuerier.GetEgress(conn.SourcePodNamespace, conn.SourcePodName) | |||
| egressName, egressIP, egressNode, err := exp.egressQuerier.GetEgress(conn.SourcePodNamespace, conn.SourcePodName) | |||
There was a problem hiding this comment.
To add a new field, please open a PR in go-ipfix repository to update the registry first.
reference PRs for adding egressName and egressIP fields: vmware/go-ipfix#308 #5088
Fixes antrea-io#5911 Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf
force-pushed
the
add-EgressNode-field-in-Traceflow-observation
branch
from
aa2bfa9
to
307b586
Compare
|
/skip-all |
1 similar comment
|
/skip-all |
tnqn
added
the
action/release-note
Fixes #5911