Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple physical interface support for secondary network bridge #5959

Merged

Conversation

aroradaman
Copy link
Contributor

@aroradaman aroradaman commented Feb 4, 2024

Given that most SR-IOV have 8 queues, this commit allows adding at most 8 physical interfaces to the secondary OVS bridge.

Fixes: #5846

@aroradaman aroradaman changed the title Allow multiple physical interface support for secondary network bridge [WIP] Allow multiple physical interface support for secondary network bridge Feb 4, 2024
@aroradaman aroradaman force-pushed the multiple-phy-dev-secondary-network branch 3 times, most recently from bcba862 to f6d15af Compare February 25, 2024 18:52
@aroradaman aroradaman force-pushed the multiple-phy-dev-secondary-network branch from 4e8145c to cc8e5bb Compare February 28, 2024 05:56
@aroradaman aroradaman marked this pull request as ready for review February 28, 2024 06:05
@aroradaman aroradaman changed the title [WIP] Allow multiple physical interface support for secondary network bridge Allow multiple physical interface support for secondary network bridge Feb 28, 2024
@jianjuns jianjuns self-requested a review February 28, 2024 06:22
@jianjuns
Copy link
Contributor

Typo in the commit message: Bride -> bridge

@aroradaman aroradaman force-pushed the multiple-phy-dev-secondary-network branch from cc8e5bb to 13d398e Compare February 28, 2024 06:29
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits.

cmd/antrea-agent/options.go Outdated Show resolved Hide resolved
cmd/antrea-agent/options_test.go Outdated Show resolved Hide resolved
docs/secondary-network.md Outdated Show resolved Hide resolved
docs/secondary-network.md Outdated Show resolved Hide resolved
pkg/agent/secondarynetwork/init.go Show resolved Hide resolved
@aroradaman aroradaman force-pushed the multiple-phy-dev-secondary-network branch from 13d398e to 911dc7f Compare February 28, 2024 20:15
Given that most SR-IOV have 8 queues, this commit allows adding
at-most 8 physical interfaces to the secondary OVS bridge.

Signed-off-by: Daman Arora <aroradaman@gmail.com>
@aroradaman aroradaman force-pushed the multiple-phy-dev-secondary-network branch from 911dc7f to c421870 Compare March 3, 2024 18:12
@aroradaman aroradaman requested a review from jianjuns March 3, 2024 18:14
@jianjuns
Copy link
Contributor

jianjuns commented Mar 3, 2024

/test-all

@jianjuns jianjuns merged commit 75205ef into antrea-io:main Mar 4, 2024
50 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutiple physical interface support for secondary network bridge
2 participants