-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record event when EgressIP remains unassigned #6011
Conversation
b710677
to
d8cee6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need unit tests to validate correct events are generated for each case.
d8cee6f
to
cf475e7
Compare
cf475e7
to
13c4377
Compare
I have added e2e test to validate the correctness of events generated in each case. |
13c4377
to
fc48567
Compare
fc48567
to
0af8495
Compare
0af8495
to
dcbd119
Compare
dcbd119
to
40e620c
Compare
e6b4362
to
2f867d7
Compare
2f867d7
to
cad78d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future PRs, please make sure the comments are really addressed, the tests can pass basic validation, and you have really confirmed answers of questions before resolving them and requesting another review.
test/e2e/egress_test.go
Outdated
@@ -600,6 +600,20 @@ func testEgressUpdateEgressIP(t *testing.T, data *TestData) { | |||
return err | |||
}) | |||
require.NoError(t, err, "Failed to update Egress") | |||
// Testing the events recorded during deletion of an Egress resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment no longer makes sense here, the events are not really specific to deletion of an Egress resource, having the comment just confuses readers.
cad78d9
to
1c232f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-e2e |
1c232f9
to
dfa547f
Compare
Modified the code to record an event for case, when an egressIP is unassigned from a node and is not assigned to any other node. Signed-off-by: Pulkit Jain <pulkit.jain@broadcom.com>
dfa547f
to
c9d82ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
1 similar comment
/skip-all |
Record event when Egress is uninstalled from a node.
FIxes #5996.