Record event when EgressIP remains unassigned #6011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainpulkit22
force-pushed
the
egress-record-update
branch
2 times, most recently
from
b710677
to
d8cee6f
Compare
jainpulkit22
changed the title
tnqn
reviewed
Feb 23, 2024
jainpulkit22
force-pushed
the
egress-record-update
branch
from
d8cee6f
to
cf475e7
Compare
jainpulkit22
force-pushed
the
egress-record-update
branch
from
cf475e7
to
13c4377
Compare
I have added e2e test to validate the correctness of events generated in each case. |
jainpulkit22
force-pushed
the
egress-record-update
branch
from
13c4377
to
fc48567
Compare
tnqn
reviewed
Mar 18, 2024
jainpulkit22
force-pushed
the
egress-record-update
branch
from
fc48567
to
0af8495
Compare
tnqn
reviewed
Apr 16, 2024
jainpulkit22
force-pushed
the
egress-record-update
branch
from
0af8495
to
dcbd119
Compare
tnqn
reviewed
Apr 19, 2024
jainpulkit22
force-pushed
the
egress-record-update
branch
from
dcbd119
to
40e620c
Compare
jainpulkit22
force-pushed
the
egress-record-update
branch
2 times, most recently
from
e6b4362
to
2f867d7
Compare
tnqn
reviewed
Apr 22, 2024
jainpulkit22
force-pushed
the
egress-record-update
branch
from
2f867d7
to
cad78d9
Compare
tnqn
reviewed
Apr 23, 2024
test/e2e/egress_test.go
Outdated
| @@ -600,6 +600,20 @@ func testEgressUpdateEgressIP(t *testing.T, data *TestData) { | |||
| return err | |||
| }) | |||
| require.NoError(t, err, "Failed to update Egress") | |||
| // Testing the events recorded during deletion of an Egress resource. | |||
There was a problem hiding this comment.
The comment no longer makes sense here, the events are not really specific to deletion of an Egress resource, having the comment just confuses readers.
jainpulkit22
force-pushed
the
egress-record-update
branch
from
cad78d9
to
1c232f9
Compare
|
/test-e2e |
jainpulkit22
force-pushed
the
egress-record-update
branch
from
1c232f9
to
dfa547f
Compare
tnqn
reviewed
Apr 24, 2024
Modified the code to record an event for case, when an egressIP is unassigned from a node and is not assigned to any other node. Signed-off-by: Pulkit Jain <pulkit.jain@broadcom.com>
jainpulkit22
force-pushed
the
egress-record-update
branch
from
dfa547f
to
c9d82ab
Compare
|
/skip-all |
1 similar comment
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record event when Egress is uninstalled from a node.
FIxes #5996.