-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L7 Network Policy Logs for Allowed HTTP #6014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example of the new log in the PR description?
Done, and updated the |
@@ -76,6 +76,12 @@ outputs: | |||
types: | |||
- alert: | |||
tagged-packets: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that determine the generation of packet
events for rejected connections when logging is enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it determines event_type: packet
log for rejected connections if enableLogging: true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this enough for fixing and closing 5982 issue?
I think yes.
The solution adds logs with event type http for allowed traffic in L7 NetworkPolicy. It also adds log support for TLS as it was later supported by L7NP. Fixes antrea-io#5982 Signed-off-by: Qiyue Yao <yaoq@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all I don't think we have an e2e test to validate logging for L7NP? |
No, there hasn't been e2e for L7NP logging. I can try to open another PR for this. |
For allowed http traffic, log in "eve-YYYY-MM-DD.json" shows
event_type: http
For dropped packets,
event_type: alert
andevent_type: packet
are stilled logged as before.Fixes #5982