Strip all debug symbols from Go binaries by default #6035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces binary sizes by around 30%, which in turn reduces the size of Antrea container images. If by any chance someone needs to create a binary / image with debug symbols, they should edit LDFLAGS / GOFLAGS in the Makefile directly. We also remove system paths from binaries using the "-trimpath" Go flag, which is best practice when shipping Go binaries. For antrea-io#5883 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
|
Uncompressed image sizes before the change: And after the change: |
tnqn
added
the
action/release-note
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces binary sizes by around 30%, which in turn reduces the size of Antrea container images.
If by any chance someone needs to create a binary / image with debug symbols, they should edit LDFLAGS / GOFLAGS in the Makefile directly.
We also remove system paths from binaries using the "-trimpath" Go flag, which is best practice when shipping Go binaries.
For #5883