-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify IPPool subnet and ExternalIPPool definitions #6036
Conversation
aeac2de
to
5f7342e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check and fix unit test failures.
5f7342e
to
87fe5c0
Compare
060ebf8
to
e63b677
Compare
@mengdie-song please resolve the code conflicts. |
b23e128
to
c2393dd
Compare
3d5ee0a
to
0661bf0
Compare
26925bf
to
a380cca
Compare
18213f2
to
95cd0aa
Compare
/test-flexible-ipam-e2e |
95cd0aa
to
6eb6bc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, @antoninbas can you take a look again? Thanks.
6eb6bc9
to
5b9d40b
Compare
5b9d40b
to
a5772a1
Compare
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
a5772a1
to
c07b1b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
/test-conformance |
Unify IPPool subnet and ExternalIPPool definitions
Make IPPoolSpec of IPPool use the same way to define IP ranges
and subnet as ExternalIPPool. With this change, one IPPool can
have multiple IP Ranges, but can only have one SubnetInfo.
Deprecated IPVersion field in IPPool definition.
Change IPPool VLAN from uint16 to int32 to be consisitent
with ExternalIPPool definition.
Promote IPPool CRD to v1beta1
Add conversion webhook to IPPool for compatibility.
Fixes:#5961
Signed-off-by: Mengdie Song songm@vmware.com