Unify IPPool subnet and ExternalIPPool definitions #6036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengdie-song
force-pushed
the
unify-ippool-def
branch
3 times, most recently
from
aeac2de
to
5f7342e
Compare
antoninbas
reviewed
Mar 1, 2024
luolanzone
reviewed
Mar 4, 2024
mengdie-song
force-pushed
the
unify-ippool-def
branch
from
5f7342e
to
87fe5c0
Compare
XinShuYang
force-pushed
the
unify-ippool-def
branch
2 times, most recently
from
060ebf8
to
e63b677
Compare
|
@mengdie-song please resolve the code conflicts. |
XinShuYang
force-pushed
the
unify-ippool-def
branch
2 times, most recently
from
b23e128
to
c2393dd
Compare
mengdie-song
force-pushed
the
unify-ippool-def
branch
3 times, most recently
from
3d5ee0a
to
0661bf0
Compare
antoninbas
reviewed
Mar 27, 2024
luolanzone
reviewed
Apr 9, 2024
XinShuYang
force-pushed
the
unify-ippool-def
branch
2 times, most recently
from
26925bf
to
a380cca
Compare
mengdie-song
force-pushed
the
unify-ippool-def
branch
2 times, most recently
from
18213f2
to
95cd0aa
Compare
|
/test-flexible-ipam-e2e |
luolanzone
reviewed
Apr 18, 2024
mengdie-song
force-pushed
the
unify-ippool-def
branch
from
95cd0aa
to
6eb6bc9
Compare
luolanzone
previously approved these changes
Apr 19, 2024
There was a problem hiding this comment.
LGTM overall, @antoninbas can you take a look again? Thanks.
mengdie-song
force-pushed
the
unify-ippool-def
branch
from
6eb6bc9
to
5b9d40b
Compare
antoninbas
reviewed
Apr 22, 2024
antoninbas
reviewed
Apr 22, 2024
XinShuYang
force-pushed
the
unify-ippool-def
branch
from
5b9d40b
to
a5772a1
Compare
tnqn
reviewed
Apr 23, 2024
tnqn
reviewed
Apr 23, 2024
1. Make IPPoolSpec of IPPool use the same way to define IP ranges and subnet as ExternalIPPool.With this change, one IPPool can have multiple IP Ranges, but it can only have one SubnetInfo, so this change also adjusts the related tests, especially the ones for antrea ipam validation. 2. Deprecated IPVersion field in IPPool definition. 3. Change IPPool VLAN from uint16 to int32 to be consisitent with ExternalIPPool definition. 4. Promote IPPool CRD to v1beta1 5. Add conversion webhook to IPPool for compatibility. Fixes:antrea-io#5961 Signed-off-by: Mengdie Song <songm@vmware.com>
mengdie-song
force-pushed
the
unify-ippool-def
branch
from
a5772a1
to
c07b1b6
Compare
antoninbas
added
the
action/release-note
antoninbas
approved these changes
Apr 24, 2024
|
/test-all |
|
/test-conformance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify IPPool subnet and ExternalIPPool definitions
Make IPPoolSpec of IPPool use the same way to define IP ranges
and subnet as ExternalIPPool. With this change, one IPPool can
have multiple IP Ranges, but can only have one SubnetInfo.
Deprecated IPVersion field in IPPool definition.
Change IPPool VLAN from uint16 to int32 to be consisitent
with ExternalIPPool definition.
Promote IPPool CRD to v1beta1
Add conversion webhook to IPPool for compatibility.
Fixes:#5961
Signed-off-by: Mengdie Song songm@vmware.com