Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce antrea cni binary size #6038

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Feb 29, 2024

It only needs a dial function but imports many unnecessary code from pkg/agent/util.

Removing the import reduces the binary size by 10MB, from 18MB to 8.4MB.

For #5883


Before:

-rwxr-xr-x  1 root root  18M Feb 29 10:10 antrea-cni

antrea/antrea-agent-ubuntu                v2.0.0-dev-d28e282d0   7e84ada052f8   15 seconds ago   350MB

After:

-rwxr-xr-x  1 root root 8.4M Feb 29 10:19 antrea-cni

antrea/antrea-agent-ubuntu                v2.0.0-dev-d28e282d0.dirty   36526d98148d   18 seconds ago   340MB

It only needs a dial function but imports many unnecessary code from
`pkg/agent/util`.

Removing the import reduces the binary size by 10MB, from 18MB to 8.4MB.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. action/release-note Indicates a PR that should be included in release notes. labels Feb 29, 2024
@tnqn
Copy link
Member Author

tnqn commented Feb 29, 2024

/test-windows-containerd-e2e

@tnqn
Copy link
Member Author

tnqn commented Feb 29, 2024

/test-all

@tnqn tnqn requested a review from antoninbas February 29, 2024 13:33
@antoninbas antoninbas merged commit 50bafd7 into antrea-io:main Feb 29, 2024
53 of 57 checks passed
@tnqn tnqn deleted the reduce-cni-size branch March 1, 2024 02:25
@antoninbas antoninbas mentioned this pull request Apr 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants