Fix Improve log when agent fails to join a new Node #6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luster Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
tnqn
reviewed
Mar 5, 2024
pkg/agent/memberlist/cluster.go
Outdated
Comment on lines
226
to
230
| errorMessage := err.Error() | ||
| prefixToRemove := "1 error occurred:" | ||
| errorMessage = strings.TrimPrefix(errorMessage, prefixToRemove) | ||
| errorMessage = strings.Replace(errorMessage, "\n\t* ", "", -1) | ||
| errorMessage = strings.TrimSpace(errorMessage) |
There was a problem hiding this comment.
This is too specific to the error's format and content. It should handle the case more generically.
Given that the type of the error returned by c.mList.Join is github.com/hashicorp/go-multierror.Error, and we know there could be at most 1 wrapped error (we only join 1 member in this case), we can just call errors.Unwrap(err) to get the wrapped error and use it in the log.
There was a problem hiding this comment.
Sure, let me check that.
roopeshsn
changed the title
Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
tnqn
added
the
kind/cleanup
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatted the error logs when the agent tries to establish a cluster with others. It will recover eventually after all agents are up.
Fixes #5966