Update Protobuf dependencies for code generation #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes our direct dependency on github.com/golang/protobuf, which has been superseded by google.golang.org/protobuf. Some notable changes since the last time we updated: * The versioning scheme for Protobuf has changed (see https://protobuf.dev/support/version-support/) * The Golang gRPC code generator is now a standalone tool (protoc-gen-go-grpc) and is no longer included as a plugin in protoc-gen-go. With protoc-gen-go-grpc, the service implementations must embed the corresponding `Unimplemented<ServiceName>Server` for future compatibility (which we are now doing for `CNIServer`). A new codegen image is released: antrea/codegen:kubernetes-1.29.2-build.0 New versions: * protoc: v26.0 * protoc-gen-go: v1.33.0 * protoc-gen-go-grpc: v1.3.0 In our case, we don't have to worry about client-server compatibility, given that antrea-cni (client) is always reinstalled by the antrea-agent Pod. Even if it was a concern for us, there has been no change in the Protobuf wire format. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
luolanzone
reviewed
Mar 21, 2024
| @@ -16,10 +16,13 @@ docker push antrea/codegen:<TAG> | |||
| The `docker push` command will fail if you do not have permission to push to the | |||
| `antrea` Dockerhub repository. | |||
|
|
|||
| The image can only be built on an x86_64 machine (no arm support). | |||
There was a problem hiding this comment.
Suggested change
| The image can only be built on an x86_64 machine (no arm support). | |
| The image can only be built on a x86_64 machine (no arm support). |
There was a problem hiding this comment.
Guess this is correct. x86's pronunciation starts with a vowel.
| @@ -0,0 +1,197 @@ | |||
| // Copyright 2019 Antrea Authors | |||
There was a problem hiding this comment.
Do you know why the year info is still 2019? is this generated manually?
There was a problem hiding this comment.
My guess is that protoc automatically uses the information from the .proto source file, but I didn't look into it.
tnqn
approved these changes
Mar 21, 2024
| @@ -16,10 +16,13 @@ docker push antrea/codegen:<TAG> | |||
| The `docker push` command will fail if you do not have permission to push to the | |||
| `antrea` Dockerhub repository. | |||
|
|
|||
| The image can only be built on an x86_64 machine (no arm support). | |||
There was a problem hiding this comment.
Guess this is correct. x86's pronunciation starts with a vowel.
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our direct dependency on github.com/golang/protobuf, which has been superseded by google.golang.org/protobuf.
Some notable changes since the last time we updated:
Unimplemented<ServiceName>Serverfor future compatibility (which we are now doing forCNIServer).A new codegen image is released: antrea/codegen:kubernetes-1.29.2-build.0
New versions:
In our case, we don't have to worry about client-server compatibility, given that antrea-cni (client) is always reinstalled by the antrea-agent Pod. Even if it was a concern for us, there has been no change in the Protobuf wire format.