Fall back to lenient decoding when strict decoding config fails #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
added
the
action/release-note
tnqn
requested review from
edwardbadboy,
antoninbas,
hangyan,
jianjuns and
luolanzone
|
The test is failed in |
The job tested wrong image, fixing it in #6157 |
antoninbas
previously approved these changes
Mar 27, 2024
test/e2e/basic_test.go
Outdated
| @@ -58,6 +59,7 @@ func TestBasic(t *testing.T) { | |||
| t.Run("testGratuitousARP", func(t *testing.T) { testGratuitousARP(t, data, data.testNamespace) }) | |||
| t.Run("testClusterIdentity", func(t *testing.T) { testClusterIdentity(t, data) }) | |||
| t.Run("testLogRotate", func(t *testing.T) { testLogRotate(t, data) }) | |||
| t.Run("testForwardCompatibility", func(t *testing.T) { testForwardCompatibility(t, data) }) | |||
There was a problem hiding this comment.
nit: I would just suggest renaming the test to testConfigForwardCompatibility
jianjuns
previously approved these changes
Mar 27, 2024
When upgrading Antrea, the config is usually updated first and there may be some new fields added to it. If a yet update agent crashes during the process, it will fail to restart due to the unknown new fields because we do strict decoding only. The patch adds lenient decoding when strict decoding fails to tolerate unknown fields and duplicate fields. Other errors like malformed data and unmatched type are still fatal. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
|
/test-all |
luolanzone
approved these changes
Mar 28, 2024
hangyan
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading Antrea, the config is usually updated first and there may be some new fields added to it. If a yet update agent crashes during the process, it will fail to restart due to the unknown new fields because we do strict decoding only.
The patch adds lenient decoding when strict decoding fails to tolerate unknown fields and duplicate fields. Other errors like malformed data and unmatched type are still fatal.
For reference, kube-proxy and kubelet have been doing this since 1.17:
https://github.com/kubernetes/kubernetes/blob/227c2e7c2b2c05a9c8b2885460e28e4da25cf558/cmd/kube-proxy/app/server.go#L491
https://github.com/kubernetes/kubernetes/blob/227c2e7c2b2c05a9c8b2885460e28e4da25cf558/pkg/kubelet/kubeletconfig/util/codec/codec.go#L76