Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation for IPPool and ExternalIPPool CRDs #6183

Merged

Conversation

antoninbas
Copy link
Contributor

When defining a pool with a CIDR, the first and the last IP address will usually be excluded. The last IP address (broadcast) is only excluded for IPv4, and, for IPPool, only if the prefix length matches the CIDR mask size.

When defining a pool with a CIDR, the first and the last IP address will
usually be excluded. The last IP address (broadcast) is only excluded
for IPv4, and, for IPPool, only if the prefix length matches the CIDR
mask size.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas added the kind/documentation Categorizes issue or PR as related to a documentation. label Apr 3, 2024
@antoninbas antoninbas requested review from tnqn and jianjuns April 3, 2024 02:16
tnqn
tnqn previously approved these changes Apr 3, 2024
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for clarifying it.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas
Copy link
Contributor Author

@tnqn I fixed a typo (second commit), PTAL

tnqn
tnqn previously approved these changes Apr 3, 2024
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/egress.md Outdated Show resolved Hide resolved
Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit 1e916ac into antrea-io:main Apr 3, 2024
49 of 52 checks passed
@antoninbas antoninbas deleted the improve-documentation-for-ip-pools branch April 3, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants