-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OVS groups to support bundle #6195
Conversation
Fixes antrea-io#6066 Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shikharish thanks for the PR. You need to add the method to mockAgentDumper
to pass the unit tests.
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
name: "SupportBundleCollection failed to dump groups", | ||
supportBundleCollection: generateSupportbundleCollection("supportBundle13", "sftp://10.220.175.92:22/root/supportbundle"), | ||
expectedCompleted: false, | ||
agentDumper: &mockAgentDumper{dumpGoroutinePprofErr: fmt.Errorf("failed to dump groups")}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should not be dumpGoroutinePprofErr
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test the command manually on a Kind cluster with Antrea to validate that group dumps are indeed included in the supportbundle?
Could you share a sample file structure as a comment to your PR to show that it is working as expected?
|
/test-all |
Fixes #6066