Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade instructions for Antrea v2.0 #6261

Merged

Conversation

antoninbas
Copy link
Contributor

Fixes #6178


If you are porting your old Antrea configuration to Antrea v2, please make sure
that you are no longer using these parameters. Unknown parameters will be
ignored by Antrea, and the behavior may not be what you expect.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnqn I think that thanks to one of your recent changes, unknown parameters will indeed be ignored instead of crashing the Agent?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I confirmed they are ignored.

@antoninbas
Copy link
Contributor Author

@luolanzone @tnqn please review. I think it is important to include this in the v2 documentation and point to it in the release notes / CHANGELOG.

@antoninbas antoninbas added this to the Antrea v2.0 release milestone Apr 25, 2024
@antoninbas antoninbas force-pushed the add-upgrade-instructions-for-antrea-v2 branch 2 times, most recently from b2356c2 to 8d61faa Compare April 25, 2024 23:06
@antoninbas antoninbas added kind/documentation Categorizes issue or PR as related to a documentation. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Apr 25, 2024
@antoninbas antoninbas force-pushed the add-upgrade-instructions-for-antrea-v2 branch 2 times, most recently from a84c9ef to e048229 Compare April 26, 2024 00:22
# Upgrade API storage for all CRDs.
# For usage information run: antctl upgrade api-storage --help
# In particular, the script will upgrade the default Tiers managed by Antrea to
# the new stored version (v1beta1) if needed. If you never installed a minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stored -> storage?


# Upgrade API storage for all CRDs.
# For usage information run: antctl upgrade api-storage --help
# In particular, the script will upgrade the default Tiers managed by Antrea to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"default Tiers" means Tier CRs? Prabably make it clear.


# Even if you didn't create any CR using the CRD API versions which have been
# removed in Antrea v2.0, you will still need to run the antctl command, or you
# the upgrade will fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or you -> or

controllerVersion: v1.13.4

# Even if you didn't create any CR using the CRD API versions which have been
# removed in Antrea v2.0, you will still need to run the antctl command, or you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or you -> or

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after existing comments are addressed.


If you are porting your old Antrea configuration to Antrea v2, please make sure
that you are no longer using these parameters. Unknown parameters will be
ignored by Antrea, and the behavior may not be what you expect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I confirmed they are ignored.

Fixes antrea-io#6178

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas force-pushed the add-upgrade-instructions-for-antrea-v2 branch from e048229 to 40969cb Compare April 26, 2024 02:52
@antoninbas
Copy link
Contributor Author

Thanks, I addressed review comments

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit 6c3bf06 into antrea-io:main Apr 26, 2024
49 of 52 checks passed
@antoninbas antoninbas deleted the add-upgrade-instructions-for-antrea-v2 branch April 26, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to a documentation. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document upgrade procedure to Antrea v2
3 participants