-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upgrade instructions for Antrea v2.0 #6261
Add upgrade instructions for Antrea v2.0 #6261
Conversation
|
||
If you are porting your old Antrea configuration to Antrea v2, please make sure | ||
that you are no longer using these parameters. Unknown parameters will be | ||
ignored by Antrea, and the behavior may not be what you expect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tnqn I think that thanks to one of your recent changes, unknown parameters will indeed be ignored instead of crashing the Agent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I confirmed they are ignored.
@luolanzone @tnqn please review. I think it is important to include this in the v2 documentation and point to it in the release notes / CHANGELOG. |
b2356c2
to
8d61faa
Compare
a84c9ef
to
e048229
Compare
docs/versioning.md
Outdated
# Upgrade API storage for all CRDs. | ||
# For usage information run: antctl upgrade api-storage --help | ||
# In particular, the script will upgrade the default Tiers managed by Antrea to | ||
# the new stored version (v1beta1) if needed. If you never installed a minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stored -> storage?
docs/versioning.md
Outdated
|
||
# Upgrade API storage for all CRDs. | ||
# For usage information run: antctl upgrade api-storage --help | ||
# In particular, the script will upgrade the default Tiers managed by Antrea to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"default Tiers" means Tier CRs? Prabably make it clear.
docs/versioning.md
Outdated
|
||
# Even if you didn't create any CR using the CRD API versions which have been | ||
# removed in Antrea v2.0, you will still need to run the antctl command, or you | ||
# the upgrade will fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or you -> or
docs/versioning.md
Outdated
controllerVersion: v1.13.4 | ||
|
||
# Even if you didn't create any CR using the CRD API versions which have been | ||
# removed in Antrea v2.0, you will still need to run the antctl command, or you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or you -> or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after existing comments are addressed.
|
||
If you are porting your old Antrea configuration to Antrea v2, please make sure | ||
that you are no longer using these parameters. Unknown parameters will be | ||
ignored by Antrea, and the behavior may not be what you expect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I confirmed they are ignored.
Fixes antrea-io#6178 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
e048229
to
40969cb
Compare
Thanks, I addressed review comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
Fixes #6178