Add documentation for the sameLabels feature in ACNP #6280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
May 1, 2024
docs/antrea-network-policy.md
Outdated
Comment on lines
1392
to
1393
| which are all isolated from each other. The reason is for the accounting or sales Namespaces, even though | ||
| they share the same value for the 'org' label, they do have different values for the 'region' label. |
There was a problem hiding this comment.
I see different ways of referring to labels ("org", 'org', org); let's be consistent with whatever we do in the rest of the document
docs/antrea-network-policy.md
Outdated
| To take the example further, if we now add another Namespace `dev` with labels "org=dev, env=test" the end | ||
| result is that only the `dev` Namespace will be selected by the `isolation-based-on-org-and-env` ACNP, which | ||
| denies ingress from all other Namespaces in the cluster since they don't have the same values for labels | ||
| "org" and "env" compared to `dev` (in fact, they don't even have all these labels). All the other |
There was a problem hiding this comment.
Suggested change
| "org" and "env" compared to `dev` (in fact, they don't even have all these labels). All the other | |
| "org" and "env" compared to `dev` (in fact, there is no other Namespace with the "env" label key). All the other |
There was a problem hiding this comment.
I think you may have missed this one
|
let's backport to Antrea v2.0, so that future patch releases include this information in their documentation |
antoninbas
added
the
kind/documentation
Dyanngg
force-pushed
the
same-labels-doc
branch
2 times, most recently
from
eb14c03
to
10f011b
Compare
antoninbas
reviewed
May 2, 2024
docs/antrea-network-policy.md
Outdated
| To take the example further, if we now add another Namespace `dev` with labels "org=dev, env=test" the end | ||
| result is that only the `dev` Namespace will be selected by the `isolation-based-on-org-and-env` ACNP, which | ||
| denies ingress from all other Namespaces in the cluster since they don't have the same values for labels | ||
| "org" and "env" compared to `dev` (in fact, they don't even have all these labels). All the other |
There was a problem hiding this comment.
I think you may have missed this one
Signed-off-by: Dyanngg <dingyang@vmware.com>
antoninbas
approved these changes
May 3, 2024
|
/skip-all |
Dyanngg
added a commit
to Dyanngg/antrea
that referenced
this pull request
May 3, 2024
Signed-off-by: Dyanngg <dingyang@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.