-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for the sameLabels feature in ACNP #6280
Conversation
docs/antrea-network-policy.md
Outdated
which are all isolated from each other. The reason is for the accounting or sales Namespaces, even though | ||
they share the same value for the 'org' label, they do have different values for the 'region' label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see different ways of referring to labels ("org", 'org', org
); let's be consistent with whatever we do in the rest of the document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/antrea-network-policy.md
Outdated
To take the example further, if we now add another Namespace `dev` with labels "org=dev, env=test" the end | ||
result is that only the `dev` Namespace will be selected by the `isolation-based-on-org-and-env` ACNP, which | ||
denies ingress from all other Namespaces in the cluster since they don't have the same values for labels | ||
"org" and "env" compared to `dev` (in fact, they don't even have all these labels). All the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"org" and "env" compared to `dev` (in fact, they don't even have all these labels). All the other | |
"org" and "env" compared to `dev` (in fact, there is no other Namespace with the "env" label key). All the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may have missed this one
let's backport to Antrea v2.0, so that future patch releases include this information in their documentation |
eb14c03
to
10f011b
Compare
docs/antrea-network-policy.md
Outdated
To take the example further, if we now add another Namespace `dev` with labels "org=dev, env=test" the end | ||
result is that only the `dev` Namespace will be selected by the `isolation-based-on-org-and-env` ACNP, which | ||
denies ingress from all other Namespaces in the cluster since they don't have the same values for labels | ||
"org" and "env" compared to `dev` (in fact, they don't even have all these labels). All the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may have missed this one
Signed-off-by: Dyanngg <dingyang@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please backport once this is merged
/skip-all |
Signed-off-by: Dyanngg <dingyang@vmware.com>
No description provided.