made sure that manager is started before staleController #6645
Conversation
|
@DarkInfernus do you have logs from before and after the change, so we can confirm that the fix is valid? |
|
Hi @antoninbas actually this is my first ever open source contribution, my pr is failing multiple checks, actually i did not check for the previous logs and after logs. I just looked at the code and as per my knowledge of go lang i think this error is happening because we are starting the go routine for running stalecontroller before starting the manager. So i thought it to be intuitive to start the go routine later. |
|
But final call should be made after checking the before logs and after logs.For that I would need to set up the project locally but unfortunately I don't know how to do that. |
|
@DarkInfernus The only way to fix this issue is to first reproduce it locally, understand the code and make the necessary changes, then confirm the issue has been resolved by testing the updated code. |
|
|
||
| klog.InfoS("Leader MC Controller Starting Manager") | ||
| if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil { | ||
| return fmt.Errorf("error running Manager: %v", err) | ||
| } | ||
|
|
||
| go staleController.Run(stopCh) |
There was a problem hiding this comment.
Hi, I don't think this change will fix the issue, please check my comment on the issue #6152 (comment).
Even we started this after the Controller Manager, it doesn't guarantee that caches are ready before it.
There was a problem hiding this comment.
Ok , i will make the required changes in the code and raise another pr.
Bug fix for the issue #6152