Add support for Namespace scoped NetworkPolicy CRD #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
jianjuns
reviewed
Jun 1, 2020
tnqn
reviewed
Jun 3, 2020
tnqn
reviewed
Jun 3, 2020
Add new CRD yamls only when explicitly set.
Move ExternalEndpoint to core group.
Address comments.
Dyanngg
force-pushed
the
ns-anp
branch
5 times, most recently
from
d6b52dd
to
1ed1e74
Compare
jianjuns
reviewed
Jun 3, 2020
- Nameport.protocol is no longer a pointer --> consistent with k8s core.servicePort - ExternalEndPoint.ip is a string ---> so it is readable to end user. - Add "omitempty" to all fields ---> we potentially can have some fields unset. - added webhook methods ---> allows ExternalEntity to hookup to webhook service.
jianjuns
approved these changes
Jun 3, 2020
|
/test-all |
|
/test-e2e |
|
/test-windows-conformance |
5 tasks
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Sep 22, 2020
* Add API types for Namespaced Antrea NetworkPolicy * Update priority to float64 Add new CRD yamls only when explicitly set. * Update apigroup for ExternalEndpoint CRD Move ExternalEndpoint to core group. * Fix name mismatch for externalNode field * Move security and core group to v1alpha1 Address comments. * Minor patches to ANP CRD types - Nameport.protocol is no longer a pointer --> consistent with k8s core.servicePort - ExternalEndPoint.ip is a string ---> so it is readable to end user. - Add "omitempty" to all fields ---> we potentially can have some fields unset. - added webhook methods ---> allows ExternalEntity to hookup to webhook service. Co-authored-by: Abhishek Raut <rauta@vmware.com> Co-authored-by: Su Wang <suw@vmware.com>
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Sep 23, 2020
* Add API types for Namespaced Antrea NetworkPolicy * Update priority to float64 Add new CRD yamls only when explicitly set. * Update apigroup for ExternalEndpoint CRD Move ExternalEndpoint to core group. * Fix name mismatch for externalNode field * Move security and core group to v1alpha1 Address comments. * Minor patches to ANP CRD types - Nameport.protocol is no longer a pointer --> consistent with k8s core.servicePort - ExternalEndPoint.ip is a string ---> so it is readable to end user. - Add "omitempty" to all fields ---> we potentially can have some fields unset. - added webhook methods ---> allows ExternalEntity to hookup to webhook service. Co-authored-by: Abhishek Raut <rauta@vmware.com> Co-authored-by: Su Wang <suw@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope of this PR is as follows:
OpenAPIv3 validation schema to validate NP spec and ensure AppliedTo and Priority (1-10000) fields are mandatory