-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rule Name in Azure Cloud NSG Rule #313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/nephe-test-e2e-agentless |
/nephe-test-e2e-agentless-upgrade |
reachjainrahul
force-pushed
the
ruleName
branch
from
September 27, 2023 20:59
778cb23
to
9609b0e
Compare
/nephe-test-e2e-agentless-upgrade |
reachjainrahul
force-pushed
the
ruleName
branch
from
September 27, 2023 21:29
9609b0e
to
d47ace2
Compare
/nephe-test-e2e-agentless |
/nephe-test-e2e-azure-upgrade |
1 similar comment
/nephe-test-e2e-azure-upgrade |
/nephe-test-e2e-aks |
Azure NSG rules will have rule name constructed as rule name within ANP + '-' + ANP name. This will provide visibility as which ANP/Rule maps to what cloud rule. Signed-off-by: Rahul Jain <rahulj@vmware.com>
reachjainrahul
force-pushed
the
ruleName
branch
from
September 28, 2023 00:32
d47ace2
to
a4626aa
Compare
/nephe-test-e2e-agentless, /nephe-test-e2e-agentless-upgrade |
/nephe-test-e2e-agentless |
/nephe-test-e2e-eks |
1 similar comment
/nephe-test-e2e-eks |
archanapholla
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure NSG rules will have a rule name constructed as the rule name within ANP + '-' + ANP name + RuleNumber. This will provide visibility as to which ANP/Rule maps to what cloud rule.