Support structured policy recommendation results #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanjunz97
force-pushed
the
structured-pr
branch
2 times, most recently
from
6dcfc9f
to
98b352c
Compare
yanjunz97
requested review from
dreamtalen,
yuntanghsu,
wsquan171 and
salv-orlando
yanjunz97
force-pushed
the
structured-pr
branch
from
98b352c
to
27041df
Compare
yuntanghsu
reviewed
Nov 14, 2022
yanjunz97
force-pushed
the
structured-pr
branch
from
27041df
to
eb24af9
Compare
| if npReco.Status.State == crdv1alpha1.NPRecommendationStateCompleted { | ||
| result, err := r.getRecommendationResult(npReco.Status.SparkApplication) | ||
| if err != nil { | ||
| klog.Warningf("Failed to get the result for completed NetworkPolicy Recommedation with id %s, error: %v", npReco.Status.SparkApplication, err) |
There was a problem hiding this comment.
do you think it might be worth populating ErrorMsg in the CRD status if we fail to fetch the results from CH?
There was a problem hiding this comment.
I updated to populate the ErrorMsg. My only concern is usually we keep consistency between status.State and status.ErrorMsg, i.e. status.ErrorMsg will be empty if the status.State is not failed. But in the case of failing to fetch the results from CH, we need to choose between
- breaking the consistency, i.e. we may have a State of Completed with some ErrorMsg
- overwriting the State value which indicates the status of the NPR CR
Currently I choose the first option. Please tell me if you have other idea for this.
yanjunz97
force-pushed
the
structured-pr
branch
from
ab1053b
to
6566be8
Compare
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
yanjunz97
force-pushed
the
structured-pr
branch
from
6566be8
to
498af35
Compare
|
/theia-test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for structured policy recommendations with the following changes:
Fix: #134
Signed-off-by: Yanjun Zhou zhouya@vmware.com