Add theia-sf (Theia Snowflake) CLI to release assets #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also add a new CLI command (theia-sf version) to display the Theia version from which the CLI was built. Signed-off-by: Antonin Bas <abas@vmware.com>
|
I imagine we are too close to the release date to get this merged for v0.4, so I added the v0.5 milestone. |
antoninbas
requested review from
yanjunz97,
dreamtalen,
heanlan,
salv-orlando and
ziyouw
dreamtalen
reviewed
Jan 28, 2023
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package version |
There was a problem hiding this comment.
Shall we put this pkg under pkg/ instead of snowflake/pkg?
There was a problem hiding this comment.
why? is it needed for other Theia code?
There was a problem hiding this comment.
BTW, given that theia and theia/snowflake are different Go modules, this is not straightforward and may not be a good idea.
There was a problem hiding this comment.
I was inspired by the version command you just added, our theia CLI doesn't have a version command so it might be useful to have one as well.
However, as you pointed out, it may not be advisable to do so across Go modules. Please disregard this comment. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also add a new CLI command (theia-sf version) to display the Theia version from which the CLI was built.
Signed-off-by: Antonin Bas abas@vmware.com