Add Egress info fields to flow table #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamtalen
force-pushed
the
egress-fields
branch
from
964f90f
to
13a9bcf
Compare
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
===========================================
- Coverage 66.56% 51.87% -14.70%
===========================================
Files 38 65 +27
Lines 4783 6747 +1964
===========================================
+ Hits 3184 3500 +316
- Misses 1452 3079 +1627
- Partials 147 168 +21
*This pull request uses carry forward flags. Click here to find out more. |
dreamtalen
force-pushed
the
egress-fields
branch
from
13a9bcf
to
f7cb899
Compare
Add two new fields EgressName, EgressIP to our flow table. Signed-off-by: Yongming Ding <dyongming@vmware.com>
dreamtalen
force-pushed
the
egress-fields
branch
from
f7cb899
to
82155e7
Compare
heanlan
reviewed
Jun 21, 2023
| @@ -190,3 +190,13 @@ INSERT INTO ".inner.flows_policy_view_local" SELECT * FROM policy_view_table_loc | |||
| DROP TABLE pod_view_table_local; | |||
| DROP TABLE node_view_table_local; | |||
| DROP TABLE policy_view_table_local; | |||
|
|
|||
| --Alter table to drop new columns | |||
| ALTER TABLE flows | |||
There was a problem hiding this comment.
Will the following statement work?
ALTER TABLE flows DROP egressName String, DROP egressIP String;
ALTER TABLE flows_local DROP egressName String, DROP egressIP String;There was a problem hiding this comment.
Sounds good, I tried this one is working:
ALTER TABLE flows
DROP COLUMN egressName,
DROP COLUMN egressIP;
Also did a similiar change on the add column statements.
| @@ -47,5 +47,7 @@ CREATE TABLE flows ( | |||
| reverseThroughputFromSourceNode NUMBER(20, 0), | |||
| reverseThroughputFromDestinationNode NUMBER(20, 0), | |||
| clusterUUID STRING(36), | |||
| timeInserted TIMESTAMP_TZ DEFAULT current_timestamp() | |||
| timeInserted TIMESTAMP_TZ DEFAULT current_timestamp(), | |||
| egressName STRING(256), | |||
There was a problem hiding this comment.
Do egressName and egressIP need to come before timeInserted in order to match the S3 csv data format? I'm not sure about whether the snowpipe copy statement will work correctly in this case or not. Have you tried that?
There was a problem hiding this comment.
They come after timeInserted actually, yes I have verified a snowflake setup manually
dreamtalen
force-pushed
the
egress-fields
branch
from
b62d9df
to
068bbc6
Compare
Signed-off-by: Yongming Ding <dyongming@vmware.com>
dreamtalen
force-pushed
the
egress-fields
branch
from
068bbc6
to
b3437d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new fields EgressName, EgressIP to our flow table.
We add these two fields in Flow Exporter/Aggregator recently: antrea-io/antrea#5088