-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Egress info fields to flow table #349
Conversation
964f90f
to
13a9bcf
Compare
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
===========================================
- Coverage 66.56% 51.87% -14.70%
===========================================
Files 38 65 +27
Lines 4783 6747 +1964
===========================================
+ Hits 3184 3500 +316
- Misses 1452 3079 +1627
- Partials 147 168 +21
*This pull request uses carry forward flags. Click here to find out more. |
13a9bcf
to
f7cb899
Compare
Add two new fields EgressName, EgressIP to our flow table. Signed-off-by: Yongming Ding <dyongming@vmware.com>
f7cb899
to
82155e7
Compare
@@ -190,3 +190,13 @@ INSERT INTO ".inner.flows_policy_view_local" SELECT * FROM policy_view_table_loc | |||
DROP TABLE pod_view_table_local; | |||
DROP TABLE node_view_table_local; | |||
DROP TABLE policy_view_table_local; | |||
|
|||
--Alter table to drop new columns | |||
ALTER TABLE flows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the following statement work?
ALTER TABLE flows DROP egressName String, DROP egressIP String;
ALTER TABLE flows_local DROP egressName String, DROP egressIP String;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I tried this one is working:
ALTER TABLE flows
DROP COLUMN egressName,
DROP COLUMN egressIP;
Also did a similiar change on the add column statements.
@@ -47,5 +47,7 @@ CREATE TABLE flows ( | |||
reverseThroughputFromSourceNode NUMBER(20, 0), | |||
reverseThroughputFromDestinationNode NUMBER(20, 0), | |||
clusterUUID STRING(36), | |||
timeInserted TIMESTAMP_TZ DEFAULT current_timestamp() | |||
timeInserted TIMESTAMP_TZ DEFAULT current_timestamp(), | |||
egressName STRING(256), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do egressName
and egressIP
need to come before timeInserted
in order to match the S3 csv data format? I'm not sure about whether the snowpipe copy statement will work correctly in this case or not. Have you tried that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They come after timeInserted actually, yes I have verified a snowflake setup manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b62d9df
to
068bbc6
Compare
Signed-off-by: Yongming Ding <dyongming@vmware.com>
068bbc6
to
b3437d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add two new fields EgressName, EgressIP to our flow table.
We add these two fields in Flow Exporter/Aggregator recently: antrea-io/antrea#5088