Fix FlowAggregator e2e test ANP deployment issue #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/theia-test-e2e |
dreamtalen
approved these changes
Jun 10, 2022
test/e2e/flowaggregator_test.go
Outdated
| } | ||
| t.Log("Network Policies are realized.") | ||
| return np1, np2 | ||
| } | ||
|
|
||
| func deployAntreaNetworkPolicies(t *testing.T, data *TestData, srcPod, dstPod string) (anp1 *secv1alpha1.NetworkPolicy, anp2 *secv1alpha1.NetworkPolicy) { | ||
| func deployAntreaNetworkPolicies(t *testing.T, data *TestData, srcPod, dstPod string, srcNode, dstNode string) (anp1 *secv1alpha1.NetworkPolicy, anp2 *secv1alpha1.NetworkPolicy) { |
There was a problem hiding this comment.
nit: srcPod, dstPod string, srcNode, dstNode string -> srcPod, dstPod, srcNode, dstNode string
The original e2e test cases only check IngressRuleTable/EgressTable flow count, and use the result to decide the if the NP rule is realized. But these two tables are used to realize K8s NP rules. For a normal ANP rule, AntreaPolicyIngressRuleTable/AntreaPolicyEgressRuleTable are used, but never checked in the case. Besides, the original case always uses number 2 to check the rule flow existence, but the fact is there always no less than 2 flows in IngressRule/EgressRule table, which are used to bypass the established and related packets in a valid connection. So the case actually doesn't check if the rule is realized or not. Signed-off-by: wenyingd <wenyingd@vmware.com> Co-authored-by: heanlan <hanlan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original e2e test cases only check IngressRuleTable/EgressTable flow
count, and use the result to decide the if the NP rule is realized. But
these two tables are used to realize K8s NP rules. For a normal ANP
rule, AntreaPolicyIngressRuleTable/AntreaPolicyEgressRuleTable are used,
but never checked in the case. Besides, the original case always uses
number 2 to check the rule flow existence, but the fact is there always
no less than 2 flows in IngressRule/EgressRule table, which are used to
bypass the established and related packets in a valid connection. So the
case actually doesn't check if the rule is realized or not.
Signed-off-by: wenyingd wenyingd@vmware.com
Co-authored-by: heanlan hanlan@vmware.com