Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI command to retrieve metrics in clickhouse database #59

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Add CLI command to retrieve metrics in clickhouse database #59

merged 1 commit into from
Aug 5, 2022

Conversation

yuntanghsu
Copy link
Contributor

@yuntanghsu yuntanghsu commented Jun 22, 2022 •
edited
Loading

Fix #54

Signed-off-by: Yun-Tang Hsu hsuy@vmware.com

@yuntanghsu yuntanghsu changed the title Theia diagnostics Add CLI command to retrive metrics in clickhouse database Jun 22, 2022
@yuntanghsu yuntanghsu marked this pull request as draft June 22, 2022 21:23
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 3 times, most recently from 37d6892 to d26aa5a Compare June 22, 2022 23:10
@yuntanghsu yuntanghsu marked this pull request as ready for review June 23, 2022 00:04
@yuntanghsu yuntanghsu changed the title Add CLI command to retrive metrics in clickhouse database Add CLI command to retrieve metrics in clickhouse database Jun 23, 2022
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 4 times, most recently from 2547849 to da17382 Compare June 24, 2022 19:24
@yuntanghsu yuntanghsu mentioned this pull request Jun 24, 2022
Merged
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 3 times, most recently from e473734 to c5592a2 Compare June 27, 2022 19:02
@yuntanghsu yuntanghsu marked this pull request as draft June 27, 2022 19:09
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 2 times, most recently from 5a82d8c to 12a7eef Compare June 27, 2022 19:40
@yuntanghsu yuntanghsu marked this pull request as ready for review June 27, 2022 19:47
@yuntanghsu yuntanghsu added this to the 0.2 milestone Jun 27, 2022
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 3 times, most recently from 985048a to 58b946a Compare June 28, 2022 23:16
yanjunz97
yanjunz97 reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to update theia-cli doc to include your commands usage instructions

pkg/theia/commands/clickhouse.go Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse.go Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 2 times, most recently from a478874 to 9d05e2f Compare July 28, 2022 22:13
dreamtalen
dreamtalen reviewed Jul 28, 2022
View reviewed changes
test/e2e/framework.go Outdated Show resolved Hide resolved
test/e2e/theia_clickhouse_test.go Outdated Show resolved Hide resolved
test/e2e/theia_clickhouse_test.go Show resolved Hide resolved
test/e2e/theia_clickhouse_test.go Outdated Show resolved Hide resolved
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 3 times, most recently from eb8f44a to 351e516 Compare July 29, 2022 17:51
yanjunz97
yanjunz97 reviewed Jul 30, 2022
View reviewed changes
docs/theia-cli.md Outdated Show resolved Hide resolved
docs/theia-cli.md Show resolved Hide resolved
test/e2e/theia_clickhouse_test.go Outdated Show resolved Hide resolved
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 4 times, most recently from ffa2b41 to 155fefe Compare August 1, 2022 20:08
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

dreamtalen
dreamtalen reviewed Aug 4, 2022
View reviewed changes
docs/theia-cli.md Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

dreamtalen
dreamtalen reviewed Aug 4, 2022
View reviewed changes
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
pkg/theia/commands/clickhouse_status.go Outdated Show resolved Hide resolved
@yuntanghsu yuntanghsu force-pushed the theia_diagnostics branch 2 times, most recently from 980136a to e857cfe Compare August 4, 2022 20:28
dreamtalen
dreamtalen approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@dreamtalen dreamtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanjunz97
yanjunz97 reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a nit.

docs/theia-cli.md Outdated Show resolved Hide resolved
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yuntanghsu
Add CLI command to retrieve metrics in clickhouse database
e4120cb 
1. Add CLI commands to get diagnostic infos about Clickhouse DB
2. Add e2e test for theia CLI

Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yuntanghsu yuntanghsu merged commit f7006e4 into antrea-io:main Aug 5, 2022
@yuntanghsu yuntanghsu deleted the theia_diagnostics branch August 5, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanjunz97 yanjunz97 yanjunz97 left review comments

@dreamtalen dreamtalen dreamtalen approved these changes

@wsquan171 wsquan171 Awaiting requested review from wsquan171

@salv-orlando salv-orlando Awaiting requested review from salv-orlando

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Theia v0.2 release
Development

Successfully merging this pull request may close these issues.

Support theia commands to get diagnostic infos about Clickhouse DB/Spark
3 participants
@yuntanghsu @dreamtalen @yanjunz97