-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClickHouse monitor e2e test #66
Conversation
/theia-test-e2e |
21dbd08
to
b75f297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
hack/generate-manifest.sh
Outdated
--ch-size <size> Deploy the ClickHouse with a specific storage size. Can be a | ||
plain integer or as a fixed-point number using one of these quantity | ||
suffixes: E, P, T, G, M, K. Or the power-of-two equivalents: | ||
Ei, Pi, Ti, Gi, Mi, Ki. The default is 8Gi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space between Ki.
and The default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed space and updated the description a little bit. Thanks!
checkClickHouseMonitorLogs(t, data, false, 0) | ||
var cmdStr string | ||
if !isIPv6 { | ||
cmdStr = fmt.Sprintf("iperf3 -u -c %s -P 128 -n 1", flow.dstIP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to have a comment here describing the choice of 128
as the max value for parallel clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, thanks!
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
Squashed commits |
Signed-off-by: Yanjun Zhou zhouya@vmware.com