Add ClickHouse monitor e2e test #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/theia-test-e2e |
yanjunz97
force-pushed
the
monitor-e2e
branch
2 times, most recently
from
21dbd08
to
b75f297
Compare
dreamtalen
reviewed
Jun 30, 2022
hack/generate-manifest.sh
Outdated
| --ch-size <size> Deploy the ClickHouse with a specific storage size. Can be a | ||
| plain integer or as a fixed-point number using one of these quantity | ||
| suffixes: E, P, T, G, M, K. Or the power-of-two equivalents: | ||
| Ei, Pi, Ti, Gi, Mi, Ki. The default is 8Gi. |
There was a problem hiding this comment.
extra space between Ki. and The default
There was a problem hiding this comment.
Removed space and updated the description a little bit. Thanks!
| checkClickHouseMonitorLogs(t, data, false, 0) | ||
| var cmdStr string | ||
| if !isIPv6 { | ||
| cmdStr = fmt.Sprintf("iperf3 -u -c %s -P 128 -n 1", flow.dstIP) |
There was a problem hiding this comment.
Better to have a comment here describing the choice of 128 as the max value for parallel clients.
|
LGTM |
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
|
Squashed commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yanjun Zhou zhouya@vmware.com