Move Grafana setting files to Persistent Storage #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage ? 38.17%
=======================================
Files ? 13
Lines ? 2174
Branches ? 0
=======================================
Hits ? 830
Misses ? 1322
Partials ? 22
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
heanlan
reviewed
Aug 3, 2022
yanjunz97
force-pushed
the
grafana-pv-settings
branch
from
3f23c73
to
da1f9ba
Compare
heanlan
approved these changes
Aug 4, 2022
docs/network-flow-visibility.md
Outdated
| Deployment restart. Other changes in settings like passwords and preferences will | ||
| also be kept. | ||
|
|
||
| In Theia 0.1, the dashboards will be lost after restarting the Grafana Deployment. |
There was a problem hiding this comment.
Suggested change
| In Theia 0.1, the dashboards will be lost after restarting the Grafana Deployment. | |
| In Theia 0.1, the changes to dashboards and settings will be lost after restarting the Grafana Deployment. |
yanjunz97
force-pushed
the
grafana-pv-settings
branch
from
da1f9ba
to
4f8401e
Compare
salv-orlando
reviewed
Aug 5, 2022
yanjunz97
force-pushed
the
grafana-pv-settings
branch
2 times, most recently
from
857aec0
to
634f01b
Compare
|
/theia-test-e2e |
yanjunz97
force-pushed
the
grafana-pv-settings
branch
from
634f01b
to
4c657fb
Compare
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
yanjunz97
force-pushed
the
grafana-pv-settings
branch
from
4c657fb
to
883666b
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Grafana settings will be lost if pod is restarted.
This PR modifies the Grafana volumes to keep the settings persistent.
The changes are as follows.
/datafrom PersistentVolume as it is not used/var/lib/grafanato PersistentVolume to make the settingspersistent
/var/lib/grafana/dashboardsto/opt/grafana/dashboardsas K8s does not allow loading directoryto PV through configmap
Signed-off-by: Yanjun Zhou zhouya@vmware.com