Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[g] parsePath 不应该直接修改 Path 的 defX / defY #1404

Closed
xiaoiver opened this issue Jul 6, 2023 · 0 comments
Closed

[g] parsePath 不应该直接修改 Path 的 defX / defY #1404

xiaoiver opened this issue Jul 6, 2023 · 0 comments
Assignees
Labels

Comments

@xiaoiver
Copy link
Contributor

xiaoiver commented Jul 6, 2023

原本 parsePath 在完成路径解析后,会保存包围盒左上角到 defX / defY 这两个属性上:

// parsePath
if (object) {
  object.parsedStyle.defX = result.rect.x;
  object.parsedStyle.defY = result.rect.y;
}

但是在 morphing 动画过程中,会首先调用该方法解析每一帧的 path,这样就会造成属性覆盖。

@xiaoiver xiaoiver self-assigned this Jul 6, 2023
@xiaoiver xiaoiver added the bug label Jul 6, 2023
xiaoiver added a commit that referenced this issue Jul 6, 2023
* fix: avoid overriding defXY when parsing path #1404

* chore: commit changeset
xiaoiver added a commit that referenced this issue Jul 6, 2023
* fix: make pick async to support impl in WebGPU (#1398)

* fix: skip loading Box2D if it's already existed #1393

* fix: update latest physx

* fix: support 2 kinds of clip z range #863

* fix: make pick async to support impl in WebGPU #1400

* fix: use async readpixels in webgl2

* fix: use premultiplied alpha in WebGL & WebGPU #1399

* fix: use createImageBitmap to create texture if possible #1401

* chore: add test case for ssr with g-webgl

* chore: adjust examples of performance block (#1402)

* chore: adjust examples of performance block

* fix: reset transform with keyword none

* chore: add ga4 key

* fix: createImageBitmap should account for error of SVG failure

* fix: avoid overriding defXY when parsing path (#1405)

* fix: avoid overriding defXY when parsing path #1404

* chore: commit changeset

* chore(release): bump version (#1403)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@xiaoiver xiaoiver closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant