Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[g-svg] client2Viewport 返回 NaN #1683

Closed
xiaoiver opened this issue May 9, 2024 · 0 comments
Closed

[g-svg] client2Viewport 返回 NaN #1683

xiaoiver opened this issue May 9, 2024 · 0 comments
Assignees
@xiaoiver
Labels
bug

Comments

@xiaoiver
Copy link
Contributor

xiaoiver commented May 9, 2024

#1677 会尝试获取 DOM 容器的 offsetWidth/Height，但 SVGElement 上没有这个属性导致计算结果返回 NaN：

下图为 @antv/component 下的报错：

截屏2024-05-09 上午11 24 50
@xiaoiver xiaoiver self-assigned this May 9, 2024
@xiaoiver xiaoiver added the bug label May 9, 2024
xiaoiver added a commit that referenced this issue May 9, 2024
@xiaoiver
fix: make sure offset widht & height existed #1683
1cabc6a
@xiaoiver xiaoiver mentioned this issue May 9, 2024
Merged
14 tasks
xiaoiver added a commit that referenced this issue May 9, 2024
@xiaoiver
fix: make sure offset widht & height existed (#1684)
5dfc52e 
* fix: make sure offset widht & height existed #1683

* chore: commit changeset
xiaoiver added a commit that referenced this issue May 9, 2024
@xiaoiver @github-actions
Release (#1686)
4c60621 
* fix: make sure offset widht & height existed (#1684)

* fix: make sure offset widht & height existed #1683

* chore: commit changeset

* chore(release): bump version (#1685)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@xiaoiver xiaoiver closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaoiver xiaoiver

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xiaoiver