fix: HTML element bounding box calculation logic #1743
#1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aarebecca
reviewed
Aug 5, 2024
| /** | ||
| * will return a new rect instance | ||
| */ | ||
| static applyTransform(rect: Rectangle, matrix: mat4) { |
There was a problem hiding this comment.
这个参考了其它 shape 的实现，发现大部分变换相关的都是在 class 里面直接实现的，目前用途相对单一，后续如果有其它模块的依赖，可以考虑重构一下作为工具函数实现
Aarebecca
approved these changes
Aug 5, 2024
wang1212
added a commit
that referenced
this pull request
Aug 5, 2024
* fix: `HTML` element bounding box calculation logic #1743 (#1744) Subtract the camera's transformation from the bounding box calculation logic of the `HTML` element to keep the result consistent with the native canvas element. * Version Packages (#1745) * chore(release): bump version * chore: update g-lite changelog --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: wang1212 <mrwang1212@126.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtract the camera's transformation from the bounding box calculation logic of the
HTMLelement to keep the result consistent with the native canvas element🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Detailed questions can be found #1743 .
The root cause is that the camera transformation and element transformation of G are independent, which means that if only the camera is adjusted, the transformation of the canvas element will not change.
However, the implementation of
getBoundingClientRect()ofHTMLtype elements simply calls the DOM API, because the transformation of the cameradivelement as the parent element is also included, which is inconsistent with the calculation logic of the canvas element.Therefore, the camera transformation needs to be eliminated in the implementation of
getBoundingClientRect()ofHTMLtype elements.📝 Changelog
HTMLelement to keep the result consistent with the native canvas element (#1743)HTML元素包围盒计算逻辑中减去相机的变换，保持和原生 canvas 元素的结果一致 (#1743)☑️ Self Check before Merge