fix: wrong y coordinate when picking with webgl (#1747) #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvisei
reviewed
Sep 23, 2024
lvisei
approved these changes
Sep 23, 2024
Aarebecca
approved these changes
Sep 24, 2024
wang1212
added a commit
that referenced
this pull request
Sep 27, 2024
* chore: setup vite dev env and update dev demos (#1776) * chore: setup env of vite dev * test: update dev demos * chore: setup vite config * chore: use different config in dev and ci env * fix: vite development server webgl package exception --------- Co-authored-by: wang1212 <mrwang1212@126.com> * fix: wrong y coordinate when picking with webgl (#1747) (#1778) * Version Packages (#1780) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix ci problems * chore: update version (#1783) * chore: fix ci problems --------- Co-authored-by: Aaron <yangtao.yangtao@antgroup.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Aarebecca
pushed a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fixed #1747
💡 Background and solution
see #1747
Because the y axis of the drawing coordinate system is downward, and the camera coordinate system is a right-handed coordinate system with its y axis pointing upward. Therefore, we only need to flip the y axis of the drawing coordinate system and pass it to the camera coordinate system.
📝 Changelog
☑️ Self Check before Merge