Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g-canvas): bbox calculation should be correct for path with arc #224

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Oct 22, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-canvas] Fix that bbox calculation is not correct for path with arc. #222
🇨🇳 Chinese 🐞 [g-canvas] 修复带有圆弧 path 的包围盒计算不正确的问题。#222

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Oct 22, 2019

Deploy preview for antv-g ready!

Built with commit 82eb88c

https://deploy-preview-224--antv-g.netlify.com

@dxq613 dxq613 merged commit edf6d69 into 4.x Oct 23, 2019
@dxq613 dxq613 deleted the fix-issue-222 branch October 23, 2019 02:37
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
fix(g-canvas): bbox calculation should be correct for path with arc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants