Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g-canvas): bbox calculation for path with angle should be accurate #259

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

dengfuping
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 夹角连接线 在水平和垂直方向的 投影 长度作为真实的线宽;
  • 考虑可能形成夹角的更多情况,比如起点和终点一致、带 Z 命令形成闭合路径等;

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-canvas] Fix that bbox calculation for path with angle is not accurate. #252
🇨🇳 Chinese 🐞 [g-canvas] 修复带角度 path 的包围盒计算不准确的问题。#252

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 5, 2019

Deploy preview for antv-g ready!

Built with commit c1a87a0

https://deploy-preview-259--antv-g.netlify.com

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 5, 2019

This pull request fixes 1 alert when merging c1a87a0 into 54abeb6 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@dxq613 dxq613 merged commit 36bb3d3 into 4.x Nov 12, 2019
@dxq613 dxq613 deleted the fix-issue-252 branch November 12, 2019 14:01
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
fix(g-canvas): bbox calculation for path with angle should be accurate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants