fix(line): series gradient

antvis · Jun 25, 2023 · 1a19741 · 1a19741
1 parent 0194cae
commit 1a19741
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 2 deletions.
diff --git a/__tests__/integration/snapshots/static/stocksLineSeriesGradient.png b/__tests__/integration/snapshots/static/stocksLineSeriesGradient.png
diff --git a/__tests__/plots/static/index.ts b/__tests__/plots/static/index.ts
@@ -261,3 +261,4 @@ export { disastersPointBubbleLegendRight } from './disasters-point-bubble-legend
 export { mockLegendColor } from './mock-legend-color';
 export { mockLegendColorSize } from './mock-legend-color-size';
 export { weatherLineMultiAxesLegend } from './weather-line-multi-axes-legend';
+export { stocksLineSeriesGradient } from './stocks-line-series-gradient';
diff --git a/__tests__/plots/static/stocks-line-series-gradient.ts b/__tests__/plots/static/stocks-line-series-gradient.ts
@@ -0,0 +1,23 @@
+import { G2Spec } from '../../../src';
+
+export function stocksLineSeriesGradient(): G2Spec {
+  return {
+    type: 'line',
+    data: {
+      type: 'fetch',
+      value: 'data/stocks.csv',
+    },
+    encode: {
+      x: (d) => new Date(d.date),
+      y: 'price',
+      series: 'symbol',
+      color: 'price',
+    },
+    legend: { size: false },
+    style: {
+      gradient: 'y',
+      strokeWidth: 10,
+      shape: 'smooth',
+    },
+  };
+}
diff --git a/src/transform/maybeGradient.ts b/src/transform/maybeGradient.ts
@@ -10,9 +10,10 @@ export type MaybeGradientOptions = Record<string, never>;
  */
 export const MaybeGradient: TC<MaybeGradientOptions> = () => {
   return (I, mark) => {
-    const { style = {} } = mark;
+    const { style = {}, encode } = mark;
+    const { series } = encode;
     const { gradient } = style;
-    if (!gradient) return [I, mark];
+    if (!gradient || series) return [I, mark];
     return [
       I,
       deepMix({}, mark, {