fix: parsePadding 不需要计算两次

antvis · May 28, 2020 · d913722 · d913722
1 parent 8410350
commit d913722
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/chart/layout/padding-cal.ts b/src/chart/layout/padding-cal.ts
@@ -27,7 +27,7 @@ export class PaddingCal {
    * 四周增加 padding
    * @param padding
    */
-  public shrink(padding: number[]): PaddingCal {
+  public shrink(padding: Padding): PaddingCal {
     const [top, right, bottom, left] = padding;
 
     this.top += top;

diff --git a/src/interface.ts b/src/interface.ts
@@ -1924,7 +1924,7 @@ export type Renderer = 'svg' | 'canvas';
 export type Datum = Record<string, any>;
 export type Data = Datum[];
 export type ActionCallback = (context: IInteractionContext) => void;
-export type Padding = number[];
+export type Padding = [number, number, number, number];
 export type ViewPadding = number | number[] | 'auto';
 export type ViewAppendPadding = number | number[];
 export type Position = [number, number];

diff --git a/src/util/bbox.ts b/src/util/bbox.ts
@@ -175,7 +175,7 @@ export class BBox {
    * @param gap
    */
   public shrink(gap: Padding): BBox {
-    const [top, right, bottom, left] = parsePadding(gap);
+    const [top, right, bottom, left] = gap;
 
     return new BBox(this.x + left, this.y + top, this.width - left - right, this.height - top - bottom);
   }
@@ -185,7 +185,7 @@ export class BBox {
    * @param bbox
    * @returns [top, right, bottom, left]
    */
-  public exceed(bbox: BBox): number[] {
+  public exceed(bbox: BBox): Padding {
     return [
       Math.max(-this.minY + bbox.minY, 0),
       Math.max(this.maxX - bbox.maxX, 0),