Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mark.liquid #5508

Merged
merged 6 commits into from
Sep 12, 2023
Merged

feat: add mark.liquid #5508

merged 6 commits into from
Sep 12, 2023

Conversation

ai-qing-hai
Copy link
Collaborator

add liquid

pearmini
pearmini requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一个 API 设计相关的问题：

__tests__/plots/static/liquid-default.ts Outdated Show resolved Hide resolved
__tests__/plots/static/liquid-pin.ts Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Sep 5, 2023
View reviewed changes
src/shape/liquid/liquid.ts Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Sep 5, 2023
View reviewed changes
src/shape/liquid/wave.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6153762094

  • 119 of 126 (94.44%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 88.571%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mark/gauge.ts 4 6 66.67%
src/shape/liquid/liquid.ts 35 37 94.59%
src/shape/liquid/wave.ts 39 42 92.86%
Totals Coverage Status
Change from base Build 6070169865: 0.001%
Covered Lines: 9935
Relevant Lines: 10854
💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Sep 11, 2023 •
edited
Loading

数据格式支持两种：

  • 直接数据（主要的写法，文档、demo 只透漏这一种）
.data(0.75)
  • 只是为了兼容旧的
.data({ percent: 0.75 })

hustcc
hustcc reviewed Sep 11, 2023
View reviewed changes
src/mark/gauge.ts Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Sep 11, 2023
View reviewed changes
src/runtime/transform.ts Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Sep 11, 2023
View reviewed changes
src/shape/liquid/liquid.ts Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Sep 11, 2023
View reviewed changes
src/shape/liquid/shapes.ts Outdated Show resolved Hide resolved
@hustcc hustcc merged commit 69540e3 into v5 Sep 12, 2023
2 checks passed
@hustcc hustcc deleted the feat-liquid branch September 12, 2023 02:00
@pearmini pearmini mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ai-qing-hai @coveralls @hustcc @pearmini