-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 3 bundle file #5597
Merged
Merged
feat: add 3 bundle file #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hustcc
commented
Sep 26, 2023
•
edited
Loading
edited
- fixed G2 多 bundle 包构建 #5592
- 3 bundle
- 按需构建,包大小优化
- 扩展包
pearmini
requested changes
Sep 26, 2023
我觉得如果入口文件都放在 src 里面会存在一些问题: 首先让人看上去有点疑惑,为啥这么多入口问题;其次这些文件只是给 UMD 用,严格来讲不是 src 的一部分。感觉更清晰的做法是额外有一个文件夹放这些入口文件?
这样保证整个 src 下面的结构更清晰。我发现 observable/plot 也有相似的结构。 |
hustcc
force-pushed
the
feat-bundle-treeshaking
branch
from
September 26, 2023 08:15
3ae9949
to
4358184
Compare
Pull Request Test Coverage Report for Build 6310723675
💛 - Coveralls |
pearmini
requested changes
Sep 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.