Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 3 bundle file #5597

Merged
merged 5 commits into from
Sep 27, 2023
Merged

feat: add 3 bundle file #5597

merged 5 commits into from
Sep 27, 2023

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Sep 26, 2023

image

  • 扩展包

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.full.ts Outdated Show resolved Hide resolved
src/api/library.ts Show resolved Hide resolved
@pearmini
Copy link
Member

pearmini commented Sep 26, 2023

我觉得如果入口文件都放在 src 里面会存在一些问题:

首先让人看上去有点疑惑,为啥这么多入口问题;其次这些文件只是给 UMD 用,严格来讲不是 src 的一部分。感觉更清晰的做法是额外有一个文件夹放这些入口文件?

  • bundle
    • g2.index.ts
    • g2-lite.index.ts
    • g2-full.index.ts
    • g2-runtime.index.ts
    • g2-plot.index.ts
  • src
    • index.ts

这样保证整个 src 下面的结构更清晰。我发现 observable/plot 也有相似的结构。

@coveralls
Copy link

coveralls commented Sep 26, 2023

Pull Request Test Coverage Report for Build 6310723675

  • 30 of 30 (100.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 88.182%

Files with Coverage Reduction New Missed Lines %
src/composition/repeatMatrix.ts 1 91.89%
Totals Coverage Status
Change from base Build 6297639807: -0.01%
Covered Lines: 10000
Relevant Lines: 10982

💛 - Coveralls

bundle/g2.std.ts Outdated Show resolved Hide resolved
src/api/chart.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
__tests__/unit/lib/lib.spec.ts Show resolved Hide resolved
@pearmini pearmini merged commit ba0c945 into v5 Sep 27, 2023
2 checks passed
@pearmini pearmini deleted the feat-bundle-treeshaking branch September 27, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants