Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 添加line默认样式 #5717

Merged
merged 1 commit into from
Nov 3, 2023
Merged

style: 添加line默认样式 #5717

merged 1 commit into from
Nov 3, 2023

Conversation

iamzone
Copy link
Contributor

@iamzone iamzone commented Nov 1, 2023

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

Fiexs #5685
折线图 line 的默认主题样式中增加 lineCap: 'round'

@iamzone
Copy link
Contributor Author

iamzone commented Nov 1, 2023

line

@pearmini
Copy link
Member

pearmini commented Nov 2, 2023

方便 rebase v5 之后再 force push 一次吗?我想测试一下这个 #5719 问题是否解决了。

@iamzone
Copy link
Contributor Author

iamzone commented Nov 2, 2023

方便rebase v5之后再强制推送一次吗?我想测试一下这个#5719问题是否解决了
需要在 v5 再合并一个 commit

@pearmini
Copy link
Member

pearmini commented Nov 2, 2023

@iamzone

需要在 v5 再合并一个 commit

这啥意思?

@iamzone
Copy link
Contributor Author

iamzone commented Nov 2, 2023

@iamzone

需要在 v5 再合并一个 commit

这啥意思?

@iamzone
Copy link
Contributor Author

iamzone commented Nov 2, 2023

@iamzone

需要在 v5 再合并一个 commit

这啥意思?

稍等,我知道为啥了

@iamzone
Copy link
Contributor Author

iamzone commented Nov 2, 2023

@iamzone

需要在 v5 再合并一个 commit

可以了

@pearmini
Copy link
Member

pearmini commented Nov 2, 2023

@iamzone

CI 可以运行了,非常感谢!

@pearmini
Copy link
Member

pearmini commented Nov 2, 2023

CI 挂了,本地运行 npm t 看看是否通过,如果截图测试报错的话,把错误的基准图片(下图中红框标出的)删除,然后重新运行 npm t 生成新截图。

image

@iamzone
Copy link
Contributor Author

iamzone commented Nov 2, 2023

CI 挂了,本地运行 npm t 看看是否通过,如果截图测试报错的话,把错误的基准图片(下图中红框标出的)删除,然后重新运行 npm t 生成新截图。

image

image
所有的截图测试都没通过

@pearmini
Copy link
Member

pearmini commented Nov 3, 2023

@iamzone 你的 node 版本和操作系统是?把 node 版本设置为 14.18 试试?

@pearmini
Copy link
Member

pearmini commented Nov 3, 2023

@iamzone 你的 node 版本和操作系统是?把 node 版本设置为 14.18 试试?

这个 PR 我先合并了,我先本地生成一下截图。

@pearmini pearmini merged commit 3df9315 into antvis:v5 Nov 3, 2023
2 of 3 checks passed
@pearmini pearmini mentioned this pull request Nov 3, 2023
@iamzone
Copy link
Contributor Author

iamzone commented Nov 3, 2023

@iamzone 你的 node 版本和操作系统是?把 node 版本设置为 14.18 试试?

image
嗯嗯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants