-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove node-canvas and use SVG snapshot instead #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoiver
force-pushed
the
test-jsdom
branch
2 times, most recently
from
November 8, 2023 07:19
948e49b
to
d8d0c42
Compare
这个 PR #5776 可能会解决某些图表坐标轴的问题 |
pearmini
approved these changes
Nov 9, 2023
终于解决测试稳定性问题了! |
ci 15min 完成,快多了~ 👍🏻👍🏻👍🏻 |
Exlau
pushed a commit
to Exlau/G2
that referenced
this pull request
Nov 10, 2023
* chore: remove node-canvas * chore: update snapshots * chore: wordcloud & heatmap test case should run on CI * chore: upload snapshots * chore: reset entity counter making snapshots stable * chore: remove canvas dep on ci * chore: add max error ratio * chore: run static-tooltip test cases * chore: skip upload cov on ci * chore: run static test cases * chore: hide axis first * chore: run chart-auto-fit test case on ci * chore: run api- test cases * chore: run interaction test cases * chore: run animation test cases * chore: run all test cases * chore: run all test cases on ci * chore: skip 2 cases * chore: run all test cases * chore: use svg renderer in unit tests * chore: upload diff html * chore: update snapshots * chore: remove oss upload script * chore: enable axis * chore: update snapshots * chore: remove test.only * chore: run skipped cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
虽然比 node-canvas 容易安装,Playwright 仍存在 CI 和本地截图的差异:
#5663
因此使用
@antv/g-svg
获取各环境一致的 SVG 字符串用作截图测试,其他渲染器的一致性应该由底层保证。为了彻底移除 node-canvas:
__tests__/unit/ssr
。G2 服务端渲染的例子可以写在 stackblitz 上,官网链接也得改一下。其他小改进:
-i
参数让测试用例并行执行,目前 ci 时间约 15min 相较之前能缩短一半。如果使用 sharding 会更快TODO: