Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Chart): Translate Chart to En #5757

Merged
merged 3 commits into from
Nov 7, 2023
Merged

docs(Chart): Translate Chart to En #5757

merged 3 commits into from
Nov 7, 2023

Conversation

owenchen1004
Copy link
Contributor

@owenchen1004 owenchen1004 commented Nov 7, 2023

Issue: #5743

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

@owenchen1004 owenchen1004 mentioned this pull request Nov 7, 2023
1 task
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一个小问题,大体都没有问题

site/docs/manual/core/chart.en.md Outdated Show resolved Hide resolved
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@pearmini pearmini merged commit 431fc9d into antvis:v5 Nov 7, 2023
2 of 3 checks passed
Exlau pushed a commit to Exlau/G2 that referenced this pull request Nov 10, 2023
* feature: translate core/chart

* fix: delete chinese in chart.en.md

* fix: Case correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants